Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: media/blink/buffered_data_source_unittest.cc

Issue 1094783002: Switch to double for time calculations using playback rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/buffered_data_source_unittest.cc
diff --git a/media/blink/buffered_data_source_unittest.cc b/media/blink/buffered_data_source_unittest.cc
index eed8674dc14bea5a80cd1a3e7adf7bb832590c77..f326daca3911d1a687a48f4963322be458984644 100644
--- a/media/blink/buffered_data_source_unittest.cc
+++ b/media/blink/buffered_data_source_unittest.cc
@@ -234,9 +234,9 @@ class BufferedDataSourceTest : public testing::Test {
return loader()->defer_strategy_;
}
int data_source_bitrate() { return data_source_->bitrate_; }
- int data_source_playback_rate() { return data_source_->playback_rate_; }
+ float data_source_playback_rate() { return data_source_->playback_rate_; }
DaleCurtis 2015/04/17 18:21:37 double?
a.berwal 2015/04/19 03:53:55 this function is not used anywhere for multiplying
xhwang 2015/04/20 21:47:07 Let's just keep using double for playback rates in
int loader_bitrate() { return loader()->bitrate_; }
- int loader_playback_rate() { return loader()->playback_rate_; }
+ float loader_playback_rate() { return loader()->playback_rate_; }
DaleCurtis 2015/04/17 18:21:37 double?
a.berwal 2015/04/19 03:53:55 this function is not used anywhere for multiplying
xhwang 2015/04/20 21:47:07 ditto
bool is_local_source() { return data_source_->assume_fully_buffered(); }
void set_might_be_reused_from_cache_in_future(bool value) {
loader()->might_be_reused_from_cache_in_future_ = value;

Powered by Google App Engine
This is Rietveld 408576698