Switch to double for time calculations using playback rate.

media/blink/buffered_data_source_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "media/base/media_log.h"
 #include "media/base/mock_filters.h"
 #include "media/base/test_helpers.h"
@@ skipping 216 matching lines @@
   WebURLLoader* url_loader() {
     return loader()->active_loader_->loader_.get();
   }
 
   BufferedDataSource::Preload preload() { return data_source_->preload_; }
   void set_preload(BufferedDataSource::Preload preload) { preload_ = preload; }
   BufferedResourceLoader::DeferStrategy defer_strategy() {
     return loader()->defer_strategy_;
   }
   int data_source_bitrate() { return data_source_->bitrate_; }
-  int data_source_playback_rate() { return data_source_->playback_rate_; }
+  float data_source_playback_rate() { return data_source_->playback_rate_; }

[DaleCurtis, 2015/04/17 18:21:37]

double?

[a.berwal, 2015/04/19 03:53:55]

this function is not used anywhere for multiplying with int64, so there is no
harm to keep it float.

[xhwang, 2015/04/20 21:47:07]

Let's just keep using double for playback rates in all places to avoid
confusion.

   int loader_bitrate() { return loader()->bitrate_; }
-  int loader_playback_rate() { return loader()->playback_rate_; }
+  float loader_playback_rate() { return loader()->playback_rate_; }

[DaleCurtis, 2015/04/17 18:21:37]

double?

[a.berwal, 2015/04/19 03:53:55]

this function is not used anywhere for multiplying with int64, so there is no
harm to keep it float.

[xhwang, 2015/04/20 21:47:07]

ditto

   bool is_local_source() { return data_source_->assume_fully_buffered(); }
   void set_might_be_reused_from_cache_in_future(bool value) {
     loader()->might_be_reused_from_cache_in_future_ = value;
   }
 
   scoped_ptr<MockBufferedDataSource> data_source_;
 
   scoped_ptr<TestResponseGenerator> response_generator_;
   MockWebFrameClient client_;
   WebView* view_;
@@ skipping 593 matching lines @@
   // Read a bit from the beginning.
   ReadAt(0);
   EXPECT_CALL(*this, ReadCallback(kDataSize));
   EXPECT_CALL(host_, AddBufferedByteRange(0, kDataSize - 1));
   ReceiveData(kDataSize);
 
   EXPECT_FALSE(active_loader());
 }
 
 }  // namespace media