Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 10947032: Re-apply: [Android] Fix WebView tests breakage after http://crrev.com/10916160 (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
erikwright (departed), Jói, android-webview-reviews
CC:
chromium-reviews
Visibility:
Public.

Description

Re-apply: [Android] Fix WebView tests breakage after http://crrev.com/10916160 Original CL: https://codereview.chromium.org/10947028 Now with DEPS update. BUG=116131 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M android_webview/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/android_webview.gyp View 4 chunks +14 lines, -0 lines 0 comments Download
M android_webview/java/android_webview_apk.xml View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +5 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
Joi, can you please take a look at DEPS file? I guess it should be ...
8 years, 3 months ago (2012-09-19 13:51:00 UTC) #1
Jói
8 years, 3 months ago (2012-09-19 14:14:31 UTC) #2
LGTM for DEPS.

Powered by Google App Engine
This is Rietveld 408576698