Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 10947028: [Android] Fix WebView tests breakage after http://crrev.com/10916160 (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
benm (inactive), android-webview-reviews
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing gyp change #

Patch Set 3 : Should compile now #

Patch Set 4 : Now really #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download
M android_webview/java/android_webview_apk.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +5 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
8 years, 3 months ago (2012-09-19 11:06:44 UTC) #1
benm (inactive)
8 years, 3 months ago (2012-09-19 11:14:18 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698