Issue 1094693002: Revert of Remove special key rewrite code for x11 (https://codereview.chromium.org/1000713003)

Issue 1094693002: Revert of Remove special key rewrite code for x11 (https://codereview.chromium.org/1000713003) (Closed)

Created:
5 years, 8 months ago by kpschoedel

Modified:
5 years, 8 months ago

Reviewers:
oshima, sadrul

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Remove special key rewrite code for x11 (https://codereview.chromium.org/1000713003) Reason for revert: breaks some keyboard layouts (crbug.com/473932) BUG=473932 TBR=oshima@chromium.org,sadrul@chromium.org Committed: https://crrev.com/04ab34e0e1833a71258962285ab1649eae951e0c Cr-Commit-Position: refs/heads/master@{#325496}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/events/event_rewriter.cc	View		1 chunk	+47 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/events/event_rewriter_unittest.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094693002/1

5 years, 8 months ago (2015-04-16 18:20:58 UTC) #2

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 8 months ago (2015-04-16 19:02:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094693002/1

5 years, 8 months ago (2015-04-16 19:23:35 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 19:26:21 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/04ab34e0e1833a71258962285ab1649eae951e0c
Cr-Commit-Position: refs/heads/master@{#325496}