Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1000713003: Remove special key rewrite code for x11 (Closed)

Created:
5 years, 9 months ago by oshima
Modified:
5 years, 9 months ago
Reviewers:
sadrul, kpschoedel
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove special key rewrite code for x11 This is no longer necessary. BUG=457948 Committed: https://crrev.com/7976f5fddee45beb19676faccc5e87bf8ae02c2e Cr-Commit-Position: refs/heads/master@{#321028}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -55 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +1 line, -47 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
oshima
5 years, 9 months ago (2015-03-11 17:28:12 UTC) #2
kpschoedel
event_rewriter_unittest crashes at line 119 because it assumes that rewriting an event with an underlying ...
5 years, 9 months ago (2015-03-11 18:23:31 UTC) #3
oshima
On 2015/03/11 18:23:31, kpschoedel wrote: > event_rewriter_unittest crashes at line 119 because it assumes that ...
5 years, 9 months ago (2015-03-11 23:26:02 UTC) #4
kpschoedel
Non-owning LGTM.
5 years, 9 months ago (2015-03-12 16:06:15 UTC) #5
oshima
sadrul?
5 years, 9 months ago (2015-03-12 16:42:24 UTC) #6
sadrul
LGTM!
5 years, 9 months ago (2015-03-12 20:26:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000713003/20001
5 years, 9 months ago (2015-03-17 23:45:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 00:17:39 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 00:18:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7976f5fddee45beb19676faccc5e87bf8ae02c2e
Cr-Commit-Position: refs/heads/master@{#321028}

Powered by Google App Engine
This is Rietveld 408576698