components/nacl/common/nacl_types.cc - Issue 1094653003: Refactor NaClProcessHost. Reduce chances to leak the resource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_types.cc

Issue 1094653003: Refactor NaClProcessHost. Reduce chances to leak the resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/common/nacl_types.h ('K') | « components/nacl/common/nacl_types.h ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/common/nacl_types.cc

diff --git a/components/nacl/common/nacl_types.cc b/components/nacl/common/nacl_types.cc

index 44a545da85cbc811296fad5ddce5ff12fa4d3fb0..1273ec638127754903d732e0fce2d5b3264cebf6 100644

--- a/components/nacl/common/nacl_types.cc

+++ b/components/nacl/common/nacl_types.cc

@@ -32,7 +32,7 @@ NaClResourcePrefetchResult::NaClResourcePrefetchResult()

}

NaClResourcePrefetchResult::NaClResourcePrefetchResult(

- IPC::PlatformFileForTransit file,

+ const IPC::PlatformFileForTransit& file,

const base::FilePath& file_path_metadata,

const std::string& file_key)

: file(file), file_path_metadata(file_path_metadata), file_key(file_key) {

@@ -98,7 +98,7 @@ NaClLaunchResult::NaClLaunchResult()

}

NaClLaunchResult::NaClLaunchResult(

- FileDescriptor imc_channel_handle,

+ const IPC::PlatformFileForTransit& imc_channel_handle,

const IPC::ChannelHandle& ppapi_ipc_channel_handle,

const IPC::ChannelHandle& trusted_ipc_channel_handle,

const IPC::ChannelHandle& manifest_service_ipc_channel_handle,