Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: components/nacl/common/nacl_types.cc

Issue 1094653003: Refactor NaClProcessHost. Reduce chances to leak the resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/common/nacl_types.h" 5 #include "components/nacl/common/nacl_types.h"
6 #include "ipc/ipc_platform_file.h" 6 #include "ipc/ipc_platform_file.h"
7 7
8 namespace nacl { 8 namespace nacl {
9 9
10 NaClStartParams::NaClStartParams() 10 NaClStartParams::NaClStartParams()
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 26
27 NaClStartParams::~NaClStartParams() { 27 NaClStartParams::~NaClStartParams() {
28 } 28 }
29 29
30 NaClResourcePrefetchResult::NaClResourcePrefetchResult() 30 NaClResourcePrefetchResult::NaClResourcePrefetchResult()
31 : file(IPC::InvalidPlatformFileForTransit()) { 31 : file(IPC::InvalidPlatformFileForTransit()) {
32 } 32 }
33 33
34 NaClResourcePrefetchResult::NaClResourcePrefetchResult( 34 NaClResourcePrefetchResult::NaClResourcePrefetchResult(
35 IPC::PlatformFileForTransit file, 35 const IPC::PlatformFileForTransit& file,
36 const base::FilePath& file_path_metadata, 36 const base::FilePath& file_path_metadata,
37 const std::string& file_key) 37 const std::string& file_key)
38 : file(file), file_path_metadata(file_path_metadata), file_key(file_key) { 38 : file(file), file_path_metadata(file_path_metadata), file_key(file_key) {
39 } 39 }
40 40
41 NaClResourcePrefetchResult::~NaClResourcePrefetchResult() { 41 NaClResourcePrefetchResult::~NaClResourcePrefetchResult() {
42 } 42 }
43 43
44 NaClResourcePrefetchRequest::NaClResourcePrefetchRequest() { 44 NaClResourcePrefetchRequest::NaClResourcePrefetchRequest() {
45 } 45 }
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 NaClLaunchResult::NaClLaunchResult() 91 NaClLaunchResult::NaClLaunchResult()
92 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()), 92 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()),
93 ppapi_ipc_channel_handle(), 93 ppapi_ipc_channel_handle(),
94 trusted_ipc_channel_handle(), 94 trusted_ipc_channel_handle(),
95 plugin_pid(base::kNullProcessId), 95 plugin_pid(base::kNullProcessId),
96 plugin_child_id(0), 96 plugin_child_id(0),
97 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) { 97 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) {
98 } 98 }
99 99
100 NaClLaunchResult::NaClLaunchResult( 100 NaClLaunchResult::NaClLaunchResult(
101 FileDescriptor imc_channel_handle, 101 const IPC::PlatformFileForTransit& imc_channel_handle,
102 const IPC::ChannelHandle& ppapi_ipc_channel_handle, 102 const IPC::ChannelHandle& ppapi_ipc_channel_handle,
103 const IPC::ChannelHandle& trusted_ipc_channel_handle, 103 const IPC::ChannelHandle& trusted_ipc_channel_handle,
104 const IPC::ChannelHandle& manifest_service_ipc_channel_handle, 104 const IPC::ChannelHandle& manifest_service_ipc_channel_handle,
105 base::ProcessId plugin_pid, 105 base::ProcessId plugin_pid,
106 int plugin_child_id, 106 int plugin_child_id,
107 base::SharedMemoryHandle crash_info_shmem_handle) 107 base::SharedMemoryHandle crash_info_shmem_handle)
108 : imc_channel_handle(imc_channel_handle), 108 : imc_channel_handle(imc_channel_handle),
109 ppapi_ipc_channel_handle(ppapi_ipc_channel_handle), 109 ppapi_ipc_channel_handle(ppapi_ipc_channel_handle),
110 trusted_ipc_channel_handle(trusted_ipc_channel_handle), 110 trusted_ipc_channel_handle(trusted_ipc_channel_handle),
111 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle), 111 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle),
112 plugin_pid(plugin_pid), 112 plugin_pid(plugin_pid),
113 plugin_child_id(plugin_child_id), 113 plugin_child_id(plugin_child_id),
114 crash_info_shmem_handle(crash_info_shmem_handle) { 114 crash_info_shmem_handle(crash_info_shmem_handle) {
115 } 115 }
116 116
117 NaClLaunchResult::~NaClLaunchResult() { 117 NaClLaunchResult::~NaClLaunchResult() {
118 } 118 }
119 119
120 } // namespace nacl 120 } // namespace nacl
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698