Issue 1094463003: Reland: Split spoken feedback up on a per format rule basis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1094463003: Reland: Split spoken feedback up on a per format rule basis. (Closed)

Created:
5 years, 8 months ago by David Tseng

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, je_julie(Not used), oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland: Split spoken feedback up on a per format rule basis. Original cl https://codereview.chromium.org/1035983003/ In order for ChromeVox to queue up utterances, we can separate each attribute or rule into its own spannable. Each spannable is then sent to tts (queueing as needed). BUG=477492 TBR=dtseng@chromium.org Committed: https://crrev.com/81a9300ad0c9ce9bb43d4cedcb1eb29450a2f7d5 Cr-Commit-Position: refs/heads/master@{#325542}

Patch Set 1 #

Patch Set 2 : Fix tests #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -161 lines)			Patch
M	chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc	View	1	8 chunks	+49 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js	View		28 chunks	+183 lines, -128 lines	0 comments	Download
M	chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs	View		1 chunk	+55 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094463003/20001

5 years, 8 months ago (2015-04-16 22:39:13 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 23:25:47 UTC) #4

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/81a9300ad0c9ce9bb43d4cedcb1eb29450a2f7d5
Cr-Commit-Position: refs/heads/master@{#325542}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages