Reland: Split spoken feedback up on a per format rule basis.

chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
@@ skipping 245 matching lines @@
     ::testing::Values(kTestAsNormalUser,
                       kTestAsGuestUser));
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, EnableSpokenFeedback) {
   EnableChromeVox();
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusToolbar) {
   EnableChromeVox();
   chrome::ExecuteCommand(browser(), IDC_FOCUS_TOOLBAR);
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
-                           "about:blank*Tool bar Reload Button"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "about:blank*"));
+  EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Reload", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, TypeInOmnibox) {
   EnableChromeVox();
 
   chrome::ExecuteCommand(browser(), IDC_FOCUS_LOCATION);
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*Edit text*"));
+  EXPECT_TRUE(
+      MatchPattern(speech_monitor_.GetNextUtterance(), "*about:blank*"));
+  EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Address and search bar", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("about:blank", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_X);
   EXPECT_EQ("x", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_Y);
   EXPECT_EQ("y", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_Z);
   EXPECT_EQ("z", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_BACK);
   EXPECT_EQ("z", speech_monitor_.GetNextUtterance());
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, FocusShelf) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::FOCUS_SHELF));
-  const char* expected = app_list::switches::IsExperimentalAppListEnabled()
-                             ? "Shelf Tool bar Launcher Button"
-                             : "Shelf Tool bar Apps Button";
-  EXPECT_EQ(expected, speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Shelf", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+  if (app_list::switches::IsExperimentalAppListEnabled())
+    EXPECT_EQ("Launcher", speech_monitor_.GetNextUtterance());
+  else
+    EXPECT_EQ("Apps", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_TAB);
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "* Button"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateAppLauncher) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::FOCUS_SHELF));
   while (true) {
     std::string utterance = speech_monitor_.GetNextUtterance();
-    if (MatchPattern(utterance, "*Button"))
+    if (MatchPattern(utterance, "Button"))
       break;
   }
 
   SendKeyPress(ui::VKEY_RETURN);
 
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
-                           "Search or type U R L Edit text"));
+  EXPECT_EQ("Search or type U R L", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_DOWN);
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "* Button"));
+  EXPECT_EQ("Dialog", speech_monitor_.GetNextUtterance());
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OpenStatusTray) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_SYSTEM_TRAY_BUBBLE));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Status tray*"));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "time *"));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
                            "Battery is*full."));
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*Button"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "*"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "Button"));
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, NavigateSystemTray) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::SHOW_SYSTEM_TRAY_BUBBLE));
   while (true) {
     std::string utterance = speech_monitor_.GetNextUtterance();
-    if (MatchPattern(utterance, "* Button"))
+    if (MatchPattern(utterance, "Button"))
       break;
   }
 
   // Navigate to Bluetooth sub-menu and open it.
   while (true) {
     SendKeyPress(ui::VKEY_TAB);
-    std::string utterance = speech_monitor_.GetNextUtterance();
-    if (MatchPattern(utterance, "*Bluetooth* Button"))
+    std::string content = speech_monitor_.GetNextUtterance();
+    std::string role = speech_monitor_.GetNextUtterance();
+    if (MatchPattern(content, "*Bluetooth*") && MatchPattern(role, "Button"))
       break;
   }
   SendKeyPress(ui::VKEY_RETURN);
 
   // Navigate to return to previous menu button and press it.
   while (true) {
     SendKeyPress(ui::VKEY_TAB);
     std::string utterance = speech_monitor_.GetNextUtterance();
-    if (MatchPattern(utterance, "Previous menu Button"))
+    if (MatchPattern(utterance, "Previous menu"))
       break;
   }
   SendKeyPress(ui::VKEY_RETURN);
-  EXPECT_TRUE(
-      MatchPattern(speech_monitor_.GetNextUtterance(), "*Bluetooth* Button"));
+
+  while (true) {
+    std::string utterance = speech_monitor_.GetNextUtterance();
+    if (MatchPattern(speech_monitor_.GetNextUtterance(), "*Bluetooth"))
+      break;
+  }
 }
 
 // See http://crbug.com/443608
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, DISABLED_ScreenBrightness) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::BRIGHTNESS_UP));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
                            "Brightness * percent"));
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::BRIGHTNESS_DOWN));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
                            "Brightness * percent"));
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, VolumeSlider) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::VOLUME_UP));
   EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "* percent*"));
   EXPECT_EQ("Volume,", speech_monitor_.GetNextUtterance());
   EXPECT_EQ("slider", speech_monitor_.GetNextUtterance());
 }
 
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, OverviewMode) {
   EnableChromeVox();
 
   EXPECT_TRUE(PerformAcceleratorAction(ash::TOGGLE_OVERVIEW));
   EXPECT_EQ("Edit text", speech_monitor_.GetNextUtterance());
-  EXPECT_EQ("Alert Entered window overview mode",
-            speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Alert", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Entered window overview mode", speech_monitor_.GetNextUtterance());
 
   SendKeyPress(ui::VKEY_TAB);
-  EXPECT_EQ("about:blank Button", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("about:blank", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 }
 
 #if defined(MEMORY_SANITIZER)
 // Fails under MemorySanitizer: http://crbug.com/472125
 #define MAYBE_ChromeVoxShiftSearch DISABLED_ChromeVoxShiftSearch
 #else
 #define MAYBE_ChromeVoxShiftSearch ChromeVoxShiftSearch
 #endif
 IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, MAYBE_ChromeVoxShiftSearch) {
   LoadChromeVoxAndThenNavigateToURL(
@@ skipping 147 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(GuestSpokenFeedbackTest);
 };
 
 IN_PROC_BROWSER_TEST_F(GuestSpokenFeedbackTest, FocusToolbar) {
   EnableChromeVox();
 
   chrome::ExecuteCommand(browser(), IDC_FOCUS_TOOLBAR);
 
-  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(),
-                           "about:blank*Tool bar Reload Button"));
+  EXPECT_TRUE(MatchPattern(speech_monitor_.GetNextUtterance(), "about:blank*"));
+  EXPECT_EQ("main", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Tool bar", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Reload", speech_monitor_.GetNextUtterance());
+  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 }
 
 //
 // Spoken feedback tests of the out-of-box experience.
 //
 
 class OobeSpokenFeedbackTest : public LoginManagerTest {
  protected:
   OobeSpokenFeedbackTest() : LoginManagerTest(false) {}
   ~OobeSpokenFeedbackTest() override {}
@@ skipping 42 matching lines @@
   ASSERT_TRUE(ui_test_utils::SendKeyPressToWindowSync(
       window, ui::VKEY_TAB, false, true /*shift*/, false, false));
   while (speech_monitor_.GetNextUtterance() != "Select your language:") {
   }
   EXPECT_EQ("English ( United States)", speech_monitor_.GetNextUtterance());
   EXPECT_TRUE(
       MatchPattern(speech_monitor_.GetNextUtterance(), "Combo box * of *"));
 }
 
 }  // namespace chromeos