Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1094333002: Reland "LayoutDescriptor should inherit from JSTypedArray" (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "LayoutDescriptor should inherit from JSTypedArray" Original issue's description: > LayoutDescriptor should inherit from JSTypedArray > > It can't just inherit from a FixedTypedArray-like type, as we soon > assume that a FixedTypedArray-like type is always held by an > ArrayBufferView-like type > > BUG=v8:3996 > R=ishell@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=ishell@chromium.org,verwaest@chromium.org LOG=n Committed: https://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1 Cr-Commit-Position: refs/heads/master@{#27973}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -20 lines) Patch
M src/factory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/factory.cc View 4 chunks +87 lines, -2 lines 0 comments Download
M src/layout-descriptor.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/layout-descriptor.cc View 1 2 3 chunks +16 lines, -6 lines 0 comments Download
M src/layout-descriptor-inl.h View 1 4 chunks +26 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
ptal since the actual values are now in a different object pointed at by elements, ...
5 years, 8 months ago (2015-04-21 14:24:48 UTC) #1
jochen (gone - plz use gerrit)
patch set #1 is the original CL, patch set #2 has the fix
5 years, 8 months ago (2015-04-21 14:25:13 UTC) #2
Igor Sheludko
lgtm
5 years, 8 months ago (2015-04-21 14:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094333002/40001
5 years, 8 months ago (2015-04-21 14:30:18 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-21 15:22:03 UTC) #7
jochen (gone - plz use gerrit)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1080403004/ by jochen@chromium.org. ...
5 years, 8 months ago (2015-04-21 15:58:02 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:23 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d20660e05eb9329cd7a0349b6afcbc794bc737c1
Cr-Commit-Position: refs/heads/master@{#27973}

Powered by Google App Engine
This is Rietveld 408576698