src/objects-printer.cc - Issue 1094333002: Reland "LayoutDescriptor should inherit from JSTypedArray"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 1094333002: Reland "LayoutDescriptor should inherit from JSTypedArray" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index cb3f27a79b0e3f8ece986a4df7bbad7d991863fe..6e30303370d647c9f88695b818cf001eb6b82fd1 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -1065,7 +1065,7 @@ void LayoutDescriptor::Print(std::ostream& os) { // NOLINT

PrintBitMask(os, static_cast<uint32_t>(Smi::cast(this)->value()));

} else {

os << "slow";

- int len = length();

+ int len = Smi::cast(length())->value();

for (int i = 0; i < len; i++) {

if (i > 0) os << " |";

PrintBitMask(os, get_scalar(i));

« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »