Redirect addr2line error output to /dev/null.

Redirect addr2line error output to /dev/null.

The clang update in r155953 introduced DWARF4 which caused older versions of addr2line to spew error messages, effectively breaking asan_symbolize.py.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157369

[scherkus (not reviewing), 2012-09-18 15:41:32]

FYI: I'm not a Python expert!

Python v3.3 introduced subprocess.DEVNULL [1] but I'm assuming that's too
futuristic for us (i.e., it doesn't run on glucid) so I went with
open(os.devnull, 'w') instead.

[1] http://docs.python.org/dev/library/subprocess.html#subprocess.DEVNULL

[Alexander Potapenko, 2012-09-18 15:47:33]

LGTM
I've checked stderr=open(os.devnull, 'w') actually suppresses stderr.

On Tue, Sep 18, 2012 at 7:41 PM,  <scherkus@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Message:
> FYI: I'm not a Python expert!
>
> Python v3.3 introduced subprocess.DEVNULL [1] but I'm assuming that's too
> futuristic for us (i.e., it doesn't run on glucid) so I went with
> open(os.devnull, 'w') instead.
>
> [1] http://docs.python.org/dev/library/subprocess.html#subprocess.DEVNULL
>
> Description:
> Redirect addr2line error output to /dev/null.
>
> The clang update in r155953 introduced DWARF4 which caused older versions of
> addr2line to spew error messages, effectively breaking asan_symbolize.py.
>
>
> Please review this at https://codereview.chromium.org/10943011/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src
>
> Affected files:
>   M tools/valgrind/asan/asan_symbolize.py
>
>
> Index: tools/valgrind/asan/asan_symbolize.py
> diff --git a/tools/valgrind/asan/asan_symbolize.py
> b/tools/valgrind/asan/asan_symbolize.py
> index
>
ad55866a8fb9b31e160afde8356cb205c800d198..508bd7f5dd5c2195f1b7820b690b9c4bca83f967
> 100755
> --- a/tools/valgrind/asan/asan_symbolize.py
> +++ b/tools/valgrind/asan/asan_symbolize.py
> @@ -32,7 +32,8 @@ def symbolize_addr2line(line):
>      addr = match.group(4)
>      if not pipes.has_key(binary):
>        pipes[binary] = subprocess.Popen(["addr2line", "-f", "-e", binary],
> -                         stdin=subprocess.PIPE, stdout=subprocess.PIPE)
> +                         stdin=subprocess.PIPE, stdout=subprocess.PIPE,
> +                         stderr=open(os.devnull, 'w'))
>      p = pipes[binary]
>      try:
>        print >>p.stdin, addr
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[commit-bot: I haz the power, 2012-09-18 16:38:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10943011/1