Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1094243004: Experiment with smaller minimum elements dictionary size (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Experiment with smaller minimum elements dictionary size BUG= Committed: https://crrev.com/b3a8f6125640133d6f37526ecb4eb984d5a78703 Cr-Commit-Position: refs/heads/master@{#28007}

Patch Set 1 #

Patch Set 2 : MErge #

Patch Set 3 : Fix merge fix #

Patch Set 4 : Go to dictionary mode more agressively for literals with numeric keys #

Patch Set 5 : We are going to 4" #

Patch Set 6 : Only reduce min capacity for small dictionaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects-inl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-22 12:39:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094243004/100001
5 years, 8 months ago (2015-04-22 12:39:44 UTC) #4
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-22 13:21:32 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:21:53 UTC) #6
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b3a8f6125640133d6f37526ecb4eb984d5a78703
Cr-Commit-Position: refs/heads/master@{#28007}

Powered by Google App Engine
This is Rietveld 408576698