Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: src/objects-inl.h

Issue 1094243004: Experiment with smaller minimum elements dictionary size (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Only reduce min capacity for small dictionaries Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3226 matching lines...) Expand 10 before | Expand all | Expand 10 after
3237 Marking::Color(array) == Marking::WHITE_OBJECT); 3237 Marking::Color(array) == Marking::WHITE_OBJECT);
3238 } 3238 }
3239 3239
3240 3240
3241 DescriptorArray::WhitenessWitness::~WhitenessWitness() { 3241 DescriptorArray::WhitenessWitness::~WhitenessWitness() {
3242 marking_->LeaveNoMarkingScope(); 3242 marking_->LeaveNoMarkingScope();
3243 } 3243 }
3244 3244
3245 3245
3246 int HashTableBase::ComputeCapacity(int at_least_space_for) { 3246 int HashTableBase::ComputeCapacity(int at_least_space_for) {
3247 const int kMinCapacity = 32; 3247 const int kMinCapacity = 4;
3248 int capacity = base::bits::RoundUpToPowerOfTwo32(at_least_space_for * 2); 3248 int capacity = base::bits::RoundUpToPowerOfTwo32(at_least_space_for * 2);
3249 if (capacity < kMinCapacity) { 3249 if (capacity < kMinCapacity) {
3250 capacity = kMinCapacity; // Guarantee min capacity. 3250 capacity = kMinCapacity; // Guarantee min capacity.
3251 } 3251 }
3252 return capacity; 3252 return capacity;
3253 } 3253 }
3254 3254
3255 3255
3256 int HashTableBase::ComputeCapacityForSerialization(int at_least_space_for) { 3256 int HashTableBase::ComputeCapacityForSerialization(int at_least_space_for) {
3257 return base::bits::RoundUpToPowerOfTwo32(at_least_space_for); 3257 return base::bits::RoundUpToPowerOfTwo32(at_least_space_for);
(...skipping 4284 matching lines...) Expand 10 before | Expand all | Expand 10 after
7542 #undef READ_SHORT_FIELD 7542 #undef READ_SHORT_FIELD
7543 #undef WRITE_SHORT_FIELD 7543 #undef WRITE_SHORT_FIELD
7544 #undef READ_BYTE_FIELD 7544 #undef READ_BYTE_FIELD
7545 #undef WRITE_BYTE_FIELD 7545 #undef WRITE_BYTE_FIELD
7546 #undef NOBARRIER_READ_BYTE_FIELD 7546 #undef NOBARRIER_READ_BYTE_FIELD
7547 #undef NOBARRIER_WRITE_BYTE_FIELD 7547 #undef NOBARRIER_WRITE_BYTE_FIELD
7548 7548
7549 } } // namespace v8::internal 7549 } } // namespace v8::internal
7550 7550
7551 #endif // V8_OBJECTS_INL_H_ 7551 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698