Refactored compound selector parsing methods.

Refactored compound selector parsing methods.

Methods for adding simple selectors to compound selectors had names like
rewriteSpecifiers. This CL tries to make more sense to it and adds
documentation for the not-so-straightforward ways of adding simple
selectors.

Renamed tagIsForNamespaceRule to tagIsImplicit as that is what it means.
The type selector is necessary as a placeholder for use during selector
matching, but not necessary to add to the serialization.

What complicates this code a lot, is the fact that we can have one or
more implicit ShadowPseudo combinators within the same compound selector,
as seen by the parser, which means it's really multiple compound
selectors. Handling these implicit combinators as true combinators in the
parser could simplify this code. See added TODO.

R=timloh@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194107

[rune, 2015-04-20 23:36:03]

Don't know how better this got, but the added documentation should help a bit.

[Timothy Loh, 2015-04-21 01:25:10]

lgtm

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
File Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
Source/core/css/parser/CSSSelectorParser.cpp:611: // in the selector parser by
pushing a token for it and exit the compound consumption.
Not sure if this is a good idea. Maybe we can come up with something better than
the current CSSParserSelector linked list?

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
Source/core/css/parser/CSSSelectorParser.cpp:615: // The code below is to keep
::content at the end of the compound, and too keep the
typo: too instead of to

[rune, 2015-04-21 09:00:08]

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
File Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
Source/core/css/parser/CSSSelectorParser.cpp:611: // in the selector parser by
pushing a token for it and exit the compound consumption.
On 2015/04/21 01:25:10, Timothy Loh wrote:
> Not sure if this is a good idea. Maybe we can come up with something better
than
> the current CSSParserSelector linked list?

I've modified the comment to say that instead.

https://codereview.chromium.org/1094213002/diff/1/Source/core/css/parser/CSSS...
Source/core/css/parser/CSSSelectorParser.cpp:615: // The code below is to keep
::content at the end of the compound, and too keep the
On 2015/04/21 01:25:10, Timothy Loh wrote:
> typo: too instead of to

Done.

[rune, 2015-04-21 09:00:25]

The CQ bit was checked by rune@opera.com

[rune, 2015-04-21 09:00:26]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1094213002/#ps40001
(title: "Addresses review issues")

[commit-bot: I haz the power, 2015-04-21 09:00:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094213002/40001

[commit-bot: I haz the power, 2015-04-21 11:05:31]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194107