Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1094213002: Refactored compound selector parsing methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addresses review issues Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | Source/core/css/parser/CSSSelectorParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSParserValues.cpp
diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp
index 93881306e8c251b2e242bc4f9fc083caac4a49ff..5765159d1c7b60b62ef2f436692b6835dda7baa8 100644
--- a/Source/core/css/parser/CSSParserValues.cpp
+++ b/Source/core/css/parser/CSSParserValues.cpp
@@ -283,8 +283,8 @@ CSSParserSelector::CSSParserSelector()
{
}
-CSSParserSelector::CSSParserSelector(const QualifiedName& tagQName)
- : m_selector(adoptPtr(new CSSSelector(tagQName)))
+CSSParserSelector::CSSParserSelector(const QualifiedName& tagQName, bool isImplicit)
+ : m_selector(adoptPtr(new CSSSelector(tagQName, isImplicit)))
{
}
@@ -353,13 +353,13 @@ void CSSParserSelector::appendTagHistory(CSSSelector::Relation relation, PassOwn
end->setTagHistory(selector);
}
-void CSSParserSelector::prependTagSelector(const QualifiedName& tagQName, bool tagIsForNamespaceRule)
+void CSSParserSelector::prependTagSelector(const QualifiedName& tagQName, bool isImplicit)
{
- OwnPtr<CSSParserSelector> second = adoptPtr(new CSSParserSelector);
+ OwnPtr<CSSParserSelector> second = CSSParserSelector::create();
second->m_selector = m_selector.release();
second->m_tagHistory = m_tagHistory.release();
m_tagHistory = second.release();
- m_selector = adoptPtr(new CSSSelector(tagQName, tagIsForNamespaceRule));
+ m_selector = adoptPtr(new CSSSelector(tagQName, isImplicit));
}
bool CSSParserSelector::hasHostPseudoSelector() const
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | Source/core/css/parser/CSSSelectorParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698