Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/lib/array_patch.dart

Issue 10942025: Convert String and List to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated to tip-of-tree. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/array_patch.dart
diff --git a/runtime/lib/array_patch.dart b/runtime/lib/array_patch.dart
index 502723685bd0961699da040bc0d59ba884059f6c..df3e9400522dcbf399ffc0577f1761883b9589a3 100644
--- a/runtime/lib/array_patch.dart
+++ b/runtime/lib/array_patch.dart
@@ -4,7 +4,7 @@
// Note that optimizing compiler depends on the algorithm which returns
// a GrowableObjectArray if length is null, otherwise returns fixed size array.
-patch class ListImplementation<E> {
+patch class List<E> {
/* patch */ factory List([int length = null]) {
srdjan 2012/09/28 17:52:22 Shouldn't the 'patch' be enabled here, since: ext
Lasse Reichstein Nielsen 2012/09/30 20:46:43 I was informed that the patch parser in the VM doe
if (length === null) {
return new GrowableObjectArray<E>();
@@ -12,12 +12,4 @@ patch class ListImplementation<E> {
return new ObjectArray<E>(length);
}
}
-
- /* patch */ static _from(Iterable other) {
- GrowableObjectArray list = new GrowableObjectArray();
- for (final e in other) {
- list.add(e);
- }
- return list;
- }
}

Powered by Google App Engine
This is Rietveld 408576698