Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: lib/core/collection.dart

Issue 10942025: Convert String and List to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated to tip-of-tree. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/core/collection.dart
diff --git a/lib/core/collection.dart b/lib/core/collection.dart
index ffad48d6c76913e76bb79efee8548fc3708b6b72..27336d831e9c6f816f2f72047b12ca5720d17163 100644
--- a/lib/core/collection.dart
+++ b/lib/core/collection.dart
@@ -32,8 +32,8 @@ abstract class Collection<E> extends Iterable<E> {
*
* collection.reduce(0, (prev, element) => prev + element);
*/
- Dynamic reduce(Dynamic initialValue,
- Dynamic combine(Dynamic previousValue, E element));
+ Dynamic reduce(var initialValue,
srdjan 2012/09/28 17:52:22 Why not remove Dynamic everywhere?
Lasse Reichstein Nielsen 2012/09/30 20:46:43 "var" is not a valid return type, and I don't like
srdjan 2012/10/02 17:21:14 This is not the the style that has been used by mo
+ Dynamic combine(var previousValue, E element));
/**
* Returns a new collection with the elements of this collection

Powered by Google App Engine
This is Rietveld 408576698