Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 10942005: Add TS_SS_TRANSITORY flag to the return value of TsfTextStore::GetStatus. (Closed)

Created:
8 years, 3 months ago by horo
Modified:
8 years, 3 months ago
Reviewers:
sky, nona, yukawa
CC:
chromium-reviews, chrome-tsf_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add TS_SS_TRANSITORY flag to the return value of TsfTextStore::GetStatus. The design of our current TsfTextStore implementation is transitory contexts. So we have to set TS_SS_TRANSITORY flag. http://blogs.msdn.com/b/tsfaware/archive/2007/04/25/transitory-contexts.aspx This change will fix the HANJA issue of Chrome Metro with MS Korean IME. BUG=148355 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157487

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/base/win/tsf_text_store.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/tsf_text_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
horo
Please review this cl.
8 years, 3 months ago (2012-09-18 05:48:57 UTC) #1
Seigo Nonaka
lgtm lgtm with nits https://codereview.chromium.org/10942005/diff/1/ui/base/win/tsf_text_store.cc File ui/base/win/tsf_text_store.cc (right): https://codereview.chromium.org/10942005/diff/1/ui/base/win/tsf_text_store.cc#newcode192 ui/base/win/tsf_text_store.cc:192: // We use transitory contexts ...
8 years, 3 months ago (2012-09-18 05:50:32 UTC) #2
horo
https://codereview.chromium.org/10942005/diff/1/ui/base/win/tsf_text_store.cc File ui/base/win/tsf_text_store.cc (right): https://codereview.chromium.org/10942005/diff/1/ui/base/win/tsf_text_store.cc#newcode192 ui/base/win/tsf_text_store.cc:192: // We use transitory contexts and we don't support ...
8 years, 3 months ago (2012-09-18 05:56:31 UTC) #3
Yohei Yukawa
lgtm
8 years, 3 months ago (2012-09-18 05:59:00 UTC) #4
horo
sky@ Cloud you please review this change? Thank you.
8 years, 3 months ago (2012-09-18 06:03:30 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-18 17:58:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/10942005/3002
8 years, 3 months ago (2012-09-18 23:23:54 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 03:59:53 UTC) #8
Change committed as 157487

Powered by Google App Engine
This is Rietveld 408576698