Cleanup: avoid foo ? true : false, part 2.

sandbox/win/src/sandbox_utils.cc

Index: sandbox/win/src/sandbox_utils.cc
===================================================================
--- sandbox/win/src/sandbox_utils.cc	(revision 157289)
+++ sandbox/win/src/sandbox_utils.cc	(working copy)
@@ -26,10 +26,8 @@
   GetModuleHandleExFunction get_module_handle_ex = reinterpret_cast<
       GetModuleHandleExFunction>(::GetProcAddress(kernel32_base,
                                                   "GetModuleHandleExW"));
-  if (get_module_handle_ex) {
-    BOOL ret = get_module_handle_ex(flags, module_name, module);
-    return (ret ? true : false);
-  }
+  if (get_module_handle_ex)
+    return !!get_module_handle_ex(flags, module_name, module);

[rvargas (doing something else), 2012/09/18 18:56:28]

This one I actually dislike a lot. how about xx != FALSE

[Lei Zhang, 2012/09/19 01:32:41]

Done.

[Peter Kasting, 2012/09/19 21:26:31]

We shouldn't need the "!!" or the "!= FALSE", should we?  Chrome style for a
long time has been to treat false and FALSE as equivalent.

[rvargas (doing something else), 2012/09/19 21:35:13]

There's the annoying "performance" warning of VS about automatically casting int
to bool :(

I'd be in favor of disabling that warning globally.

 
   if (!flags) {
     *module = ::LoadLibrary(module_name);