Cleanup: avoid foo ? true : false, part 2.

sandbox/win/src/sandbox_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/sandbox_utils.h"
 
 #include <windows.h>
 
 #include "base/logging.h"
 #include "base/win/windows_version.h"
 #include "sandbox/win/src/internal_types.h"
 #include "sandbox/win/src/nt_internals.h"
 
 namespace sandbox {
 
 bool GetModuleHandleHelper(DWORD flags, const wchar_t* module_name,
                            HMODULE* module) {
   DCHECK(module);
 
   HMODULE kernel32_base = ::GetModuleHandle(kKerneldllName);
   if (!kernel32_base) {
     NOTREACHED();
     return false;
   }
 
   GetModuleHandleExFunction get_module_handle_ex = reinterpret_cast<
       GetModuleHandleExFunction>(::GetProcAddress(kernel32_base,
                                                   "GetModuleHandleExW"));
-  if (get_module_handle_ex) {
-    BOOL ret = get_module_handle_ex(flags, module_name, module);
-    return (ret ? true : false);
-  }
+  if (get_module_handle_ex)
+    return !!get_module_handle_ex(flags, module_name, module);

[rvargas (doing something else), 2012/09/18 18:56:28]

This one I actually dislike a lot. how about xx != FALSE

[Lei Zhang, 2012/09/19 01:32:41]

Done.

[Peter Kasting, 2012/09/19 21:26:31]

We shouldn't need the "!!" or the "!= FALSE", should we?  Chrome style for a
long time has been to treat false and FALSE as equivalent.

[rvargas (doing something else), 2012/09/19 21:35:13]

There's the annoying "performance" warning of VS about automatically casting int
to bool :(

I'd be in favor of disabling that warning globally.

 
   if (!flags) {
     *module = ::LoadLibrary(module_name);
   } else if (flags & GET_MODULE_HANDLE_EX_FLAG_PIN) {
     NOTREACHED();
     return false;
   } else if (!(flags & GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS)) {
     DCHECK((flags & GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT) ==
            GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT);
 
@@ skipping 27 matching lines @@
     HMODULE ntdll = ::GetModuleHandle(kNtdllName);
     RtlInitUnicodeString = reinterpret_cast<RtlInitUnicodeStringFunction>(
       GetProcAddress(ntdll, "RtlInitUnicodeString"));
     DCHECK(RtlInitUnicodeString);
   }
   RtlInitUnicodeString(uni_name, name.c_str());
   InitializeObjectAttributes(obj_attr, uni_name, attributes, root, NULL);
 }
 
 };  // namespace sandbox