Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 1094153002: Move ClosePage() from RenderViewHost to WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 09ecb598b4250e533c1b2f01a295712568b87c2a..01dd5b0ad2ce7da5e2ff9901817891da06a19680 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -474,7 +474,7 @@ bool RenderFrameDevToolsAgentHost::Activate() {
bool RenderFrameDevToolsAgentHost::Close() {
if (render_frame_host_) {
- render_frame_host_->GetRenderViewHost()->ClosePage();
+ WebContentsImpl::FromRenderFrameHost(render_frame_host_)->ClosePage();
dgozman 2015/04/21 05:13:32 if (web_contents()) web_contents()->ClosePage();
nasko 2015/04/29 17:09:27 That looks fine to me. What I found strange is few
dgozman 2015/04/29 17:23:42 web_contents() is a protected method of WCO, and w
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698