Move ClosePage() from RenderViewHost to WebContents.

content/browser/devtools/render_frame_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/child_process_security_policy_impl.h"
@@ skipping 456 matching lines @@
 bool RenderFrameDevToolsAgentHost::Activate() {
   if (render_frame_host_) {
     render_frame_host_->GetRenderViewHost()->GetDelegate()->Activate();
     return true;
   }
   return false;
 }
 
 bool RenderFrameDevToolsAgentHost::Close() {
   if (render_frame_host_) {
-    render_frame_host_->GetRenderViewHost()->ClosePage();
+    WebContentsImpl::FromRenderFrameHost(render_frame_host_)->ClosePage();

[dgozman, 2015/04/21 05:13:32]

if (web_contents())
  web_contents()->ClosePage();

[nasko, 2015/04/29 17:09:27]

That looks fine to me. What I found strange is few places in this file use
WebContents* web_contents = GetWebContents(); which just returns web_contents().
Should this be cleaned up?

[dgozman, 2015/04/29 17:23:42]

web_contents() is a protected method of WCO, and we need a public one, which is
called GetWebContents(). I personally don't have preference for one over
another, but I'm open for improvements if you have any suggestions.

     return true;
   }
   return false;
 }
 
 void RenderFrameDevToolsAgentHost::ConnectRenderFrameHost(
     RenderFrameHost* rfh) {
   SetRenderFrameHost(rfh);
   if (IsAttached())
     Reattach();
@@ skipping 39 matching lines @@
   if (!IsAttached() || !render_frame_host_)
     return;
   ProcessChunkedMessageFromAgent(message);
 }
 
 bool RenderFrameDevToolsAgentHost::IsChildFrame() {
   return render_frame_host_ && render_frame_host_->GetParent();
 }
 
 }  // namespace content