Don't generate FooList if it behaves like List<Foo> exactly.

Don't generate FooList if it behaves like List<Foo> exactly.
Committed: https://code.google.com/p/dart/source/detail?r=12799

[Emily Fortuna, 2012-09-19 21:06:40]

I'm open to structural change suggestions for this code if you have them, so
that changes aren't spread across so many files.

This patch doesn't cover any of the DOM List-like types that have additional
methods.

[Emily Fortuna, 2012-09-19 21:08:47]

Just a little more background on this change. This changes types like FileList
to now only be usable as List<File> (removing FileList from the public
interface). Under the covers, however, we still have FileListImpl, so that we
can be smarter about the specific type information in the implementation.

[Emily Fortuna, 2012-09-20 20:50:40]

PTAL

[Emily Fortuna, 2012-09-20 20:51:36]

PTAL -- this change is only for immutable list-like interfaces that do not have
any setters or accept List<Foo> as input anywhere. The more complicated cases
will be handled in a later CL.

[vsm, 2012-09-21 15:17:33]

https://chromiumcodereview.appspot.com/10941047/diff/24001/lib/html/dart2js/h...
File lib/html/dart2js/html_dart2js.dart (right):

https://chromiumcodereview.appspot.com/10941047/diff/24001/lib/html/dart2js/h...
lib/html/dart2js/html_dart2js.dart:18182: +abstract class List<CSSRule>
implements List<CSSRule> {
This looks broken - it's basically redeclaring List in terms of itself.  Can you
suppress these declarations?

Is dart2js accepting this code?  If so, please file a bug on them.

[Emily Fortuna, 2012-09-21 18:32:15]

PTAL.  I had uploaded a bad version of the generated file last time.

https://chromiumcodereview.appspot.com/10941047/diff/24001/lib/html/dart2js/h...
File lib/html/dart2js/html_dart2js.dart (right):

https://chromiumcodereview.appspot.com/10941047/diff/24001/lib/html/dart2js/h...
lib/html/dart2js/html_dart2js.dart:18182: +abstract class List<CSSRule>
implements List<CSSRule> {
No, this was an accident I uploaded this. This was an old version. I re-uploaded
the latest generated code. 

On 2012/09/21 15:17:33, vsm wrote:
> This looks broken - it's basically redeclaring List in terms of itself.  Can
you
> suppress these declarations?
> 
> Is dart2js accepting this code?  If so, please file a bug on them.

[vsm, 2012-09-21 22:43:12]

Much better.  :-)

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/g...
File lib/html/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/g...
lib/html/scripts/generator.py:947: nativified_classes = {}
How about calling this suppressed_classes?

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/s...
File lib/html/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/s...
lib/html/scripts/systemhtml.py:461: is_native_class = filename[:-len('.dart')]
in nativified_classes.values()
This feels brittle.  If we change the file naming convention, a bunch of types
will
mysteriously appear.  Can you fix this upstream to not emit if the type name is
nativified?

[Emily Fortuna, 2012-09-22 00:13:52]

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/s...
File lib/html/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10941047/diff/20002/lib/html/scripts/s...
lib/html/scripts/systemhtml.py:461: is_native_class = filename[:-len('.dart')]
in nativified_classes.values()
On 2012/09/21 22:43:12, vsm wrote:
> This feels brittle.  If we change the file naming convention, a bunch of types
> will
> mysteriously appear.  Can you fix this upstream to not emit if the type name
is
> nativified?

Unfortunately not. The backend _Impl files are very tightly coupled with the
front end interfaces. It constructs the backend implementations by using the
members added to the front end interface. So you have to actually allow the
construction of the front-facing interface to complete in order for the backends
to also build.

[Emily Fortuna, 2012-09-24 19:28:30]

PTAL. This time for real! :-)

[vsm, 2012-09-24 19:31:10]

lgtm

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/systemht...
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/systemht...
lib/html/scripts/systemhtml.py:479: if (not self._interface.id in
_merged_html_interfaces and
Can you add a comment here?

[Emily Fortuna, 2012-09-24 19:42:58]

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/systemht...
File lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/systemht...
lib/html/scripts/systemhtml.py:479: if (not self._interface.id in
_merged_html_interfaces and
On 2012/09/24 19:31:10, vsm wrote:
> Can you add a comment here?

Done.

[Sean Eagan, 2012-09-24 20:38:33]

https://codereview.chromium.org/10941047/diff/21004/lib/html/dart2js/html_dar...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/10941047/diff/21004/lib/html/dart2js/html_dar...
lib/html/dart2js/html_dart2js.dart:12754: +typedef bool
EntriesCallback(List<EntryArray> entries);
List<Entry> ?

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/generato...
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/generato...
lib/html/scripts/generator.py:893: 'EntryArray': TypeData(clazz='Interface',
dart_type='List<EntryArray>',
List<Entry> ?

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/generato...
lib/html/scripts/generator.py:896: dart_type='List<EntryArraySync>',
custom_to_native=True,
List<EntrySync> ?

[Emily Fortuna, 2012-09-24 21:18:34]

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/generato...
File lib/html/scripts/generator.py (right):

https://codereview.chromium.org/10941047/diff/21004/lib/html/scripts/generato...
lib/html/scripts/generator.py:896: dart_type='List<EntryArraySync>',
custom_to_native=True,
On 2012/09/24 20:38:34, seaneagan1 wrote:
> List<EntrySync> ?

These got dropped accidentally in the move from htmlrenamer.py to generator.py
(See patchset 1 of this CL. A revised (fixed) version of this CL is now at
https://codereview.chromium.org/10957066)