Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 10957066: Reapply 12799. (Closed)

Created:
8 years, 2 months ago by Emily Fortuna
Modified:
8 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+849 lines, -1403 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 77 chunks +38 lines, -343 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 295 chunks +740 lines, -1042 lines 0 comments Download
M lib/html/idl/dart/dart.idl View 2 chunks +1 line, -1 line 0 comments Download
M lib/html/scripts/generator.py View 1 5 chunks +51 lines, -3 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/scripts/systemdart2js.py View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 4 chunks +11 lines, -5 lines 0 comments Download
M lib/html/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/dart2js_Conversions.dart View 1 chunk +1 line, -4 lines 0 comments Download
M lib/html/templates/immutable_list_mixin.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
https://codereview.chromium.org/10957066/diff/2001/lib/html/scripts/generator.py File lib/html/scripts/generator.py (right): https://codereview.chromium.org/10957066/diff/2001/lib/html/scripts/generator.py#newcode953 lib/html/scripts/generator.py:953: html_interface_renames[key] = value.dart_type This line is the one addition ...
8 years, 2 months ago (2012-09-24 20:19:52 UTC) #1
vsm
8 years, 2 months ago (2012-09-24 20:31:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698