Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10941040: linux_aura: Make combo boxes work with DesktopRootWindowHostLinux. (Closed)

Created:
8 years, 3 months ago by Elliot Glaysher
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Make combo boxes work with DesktopRootWindowHostLinux. - Fix subwindow transience so we don't dismiss on focus. - Several fixes around bounds. (Note: the whole client bounds isn't working correctly yet.) - A real LayoutManager that keeps the main content window in sync with the root window. BUG=146077 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157665

Patch Set 1 #

Patch Set 2 : Get rid of testing dlogs #

Total comments: 2

Patch Set 3 : Move the DesktopLayoutManager to ui/views/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -61 lines) Patch
M ui/views/views.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/views/widget/desktop_layout_manager.h View 1 2 2 chunks +18 lines, -25 lines 0 comments Download
A ui/views/widget/desktop_layout_manager.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.cc View 1 2 12 chunks +75 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
8 years, 3 months ago (2012-09-19 20:28:51 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/10941040/diff/2001/ui/aura/desktop/desktop_layout_manager.h File ui/aura/desktop/desktop_layout_manager.h (right): https://codereview.chromium.org/10941040/diff/2001/ui/aura/desktop/desktop_layout_manager.h#newcode5 ui/aura/desktop/desktop_layout_manager.h:5: #ifndef UI_AURA_DESKTOP_DESKTOP_LAYOUT_MANAGER_H_ put this file in ui/views/widget/ alongside the ...
8 years, 3 months ago (2012-09-19 21:29:23 UTC) #2
Elliot Glaysher
ptal
8 years, 3 months ago (2012-09-19 21:54:00 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-19 22:09:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10941040/3009
8 years, 3 months ago (2012-09-19 22:13:22 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 00:11:03 UTC) #6
Change committed as 157665

Powered by Google App Engine
This is Rietveld 408576698