components/signin/core/browser/fake_auth_status_provider.h - Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/fake_auth_status_provider.h

Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/about_signin_internals.cc ('k') | components/signin/core/browser/fake_auth_status_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/fake_auth_status_provider.h

diff --git a/components/signin/core/browser/fake_auth_status_provider.h b/components/signin/core/browser/fake_auth_status_provider.h

index ce2cca921af89036432dc56d74d547b47536d0a0..48a03787ea1d353ff9b61ac1f0e4d5b905a00524 100644

--- a/components/signin/core/browser/fake_auth_status_provider.h

+++ b/components/signin/core/browser/fake_auth_status_provider.h

@@ -19,7 +19,6 @@ class FakeAuthStatusProvider

// Sets the auth error that this provider reports to SigninErrorController.

// Also notifies SigninErrorController via AuthStatusChanged().

void SetAuthError(const std::string& account_id,

- const std::string& username,

const GoogleServiceAuthError& error);

void set_error_without_status_change(const GoogleServiceAuthError& error) {

@@ -28,13 +27,11 @@ class FakeAuthStatusProvider

// AuthStatusProvider implementation.

std::string GetAccountId() const override;

- std::string GetUsername() const override;

GoogleServiceAuthError GetAuthStatus() const override;

private:

SigninErrorController* error_provider_;

std::string account_id_;

- std::string username_;

GoogleServiceAuthError auth_error_;

};