components/signin/core/browser/about_signin_internals.cc - Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('k') | components/signin/core/browser/fake_auth_status_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/about_signin_internals.cc

diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc

index 74c3979bfe00baae87ba26937a050bf9306c21dc..2c7d3cbb3d8922b8da3839b4f85642abde1bdcd8 100644

--- a/components/signin/core/browser/about_signin_internals.cc

+++ b/components/signin/core/browser/about_signin_internals.cc

@@ -505,10 +505,14 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue(

static_cast<UntimedSigninStatusField>(USERNAME)),

signin_manager->GetAuthenticatedUsername());

if (signin_error_controller->HasError()) {

+ const std::string error_account_id =

+ signin_error_controller->error_account_id();

+ const std::string error_username =

+ account_tracker->GetAccountInfo(error_account_id).email;

AddSectionEntry(basic_info, "Auth Error",

signin_error_controller->auth_error().ToString());

- AddSectionEntry(basic_info, "Auth Error Username",

- signin_error_controller->error_username());

+ AddSectionEntry(basic_info, "Auth Error Account Id", error_account_id);

+ AddSectionEntry(basic_info, "Auth Error Username", error_username);

} else {

AddSectionEntry(basic_info, "Auth Error", "None");

}