 Chromium Code Reviews
 Chromium Code Reviews Issue 1094103005:
  Profile chooser on mac was passing wrong value to signin error controller.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1094103005:
  Profile chooser on mac was passing wrong value to signin error controller.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: components/signin/core/browser/about_signin_internals.cc | 
| diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc | 
| index 81a7e61406634566482e85541d6437d69474d854..7b54067162aaa7d0897499146a5bece8ba3d1485 100644 | 
| --- a/components/signin/core/browser/about_signin_internals.cc | 
| +++ b/components/signin/core/browser/about_signin_internals.cc | 
| @@ -546,10 +546,14 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue( | 
| static_cast<UntimedSigninStatusField>(USERNAME)), | 
| signin_manager->GetAuthenticatedUsername()); | 
| if (signin_error_controller->HasError()) { | 
| + std::string error_account_id = | 
| 
Mike Lerman
2015/04/24 19:36:26
nit: Can this and just below be const std::string&
 
Roger Tawa OOO till Jul 10th
2015/04/27 20:31:59
Done.
 | 
| + signin_error_controller->error_account_id(); | 
| + std::string error_username = | 
| + account_tracker->GetAccountInfo(error_account_id).email; | 
| AddSectionEntry(basic_info, "Auth Error", | 
| signin_error_controller->auth_error().ToString()); | 
| - AddSectionEntry(basic_info, "Auth Error Username", | 
| - signin_error_controller->error_username()); | 
| + AddSectionEntry(basic_info, "Auth Error Account Id", error_account_id); | 
| + AddSectionEntry(basic_info, "Auth Error Username", error_username); | 
| } else { | 
| AddSectionEntry(basic_info, "Auth Error", "None"); | 
| } |