chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 1094103005: Profile chooser on mac was passing wrong value to signin error controller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ASI Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/profiles/profile_chooser_view.cc ('K') | « chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc ('k') | components/signin/core/browser/about_signin_internals.cc » ('j') | components/signin/core/browser/about_signin_internals.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index 697d92f1debc28f5e1f56c011997e2e6c8dae90c..aa419e4c3f6e1eaa15049066ec8ca5a4ea46f34b 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -642,7 +642,9 @@ void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {

&validate_email) &&

validate_email == "1") {

if (!gaia::AreEmailsSame(email, default_email)) {

- SyncStarterCallback(OneClickSigninSyncStarter::SYNC_SETUP_FAILURE);

+ HandleLoginError(

+ l10n_util::GetStringFUTF8(IDS_SYNC_WRONG_EMAIL,

+ base::UTF8ToUTF16(default_email)));

return;

}