Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp

Issue 1094103003: [NaCl SDK] Compile libppapi_stub.a with -fPIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp
diff --git a/ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp b/ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp
index c00cf980e9f8c18f7d668281272e4ca4b0caf650..e1b2d85b6ea65a5accdc353fdbb54e3348758f4a 100644
--- a/ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp
+++ b/ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp
@@ -16,6 +16,10 @@
'build_newlib': 1,
'build_pnacl_newlib': 1,
},
+ # Always compile libppapi_stub with -fPIC so that -lppapi can be linked
+ # into shared libraries (libppapi.so is a linker script that pulls in
+ # ppapi_stub).
+ 'compile_flags': [ '-fPIC' ],
'include_dirs': [
'../../../..',
],

Powered by Google App Engine
This is Rietveld 408576698