[Android] Upstream the WebView find-in-page API implementation.

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index a6647c12a00a791e104472d4aa7bf1000e083001..18b116859e0df6a4e1acf2f3a00b566701ef3433 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -1007,6 +1007,23 @@ IPC_MESSAGE_ROUTED0(ViewMsg_Stop)
 // Tells the renderer to reload the current focused frame
 IPC_MESSAGE_ROUTED0(ViewMsg_ReloadFrame)
 
+#if defined(OS_ANDROID)

[jam, 2012/09/19 16:55:43]

nit: put all the android specific messages together in one ifdef block, at the
end of the declaration of the IPC messages (i.e. right before "Messages sent
from the renderer to the browser.")

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+// Sent when the user wants to search for all occurrences of a word or find
+// the next result in a synchronous way. This method forces the UI thread in
+// the browser to wait for the renderer to reply, therefore blocking the UI.
+//
+// This functionality is required for compatibility with the legacy Android
+// WebView API. As this goes strongly against the Chromium design guidelines,
+// this message should not be used for any other purposes.

[jam, 2012/09/19 16:55:43]

nit: this message _can't_ be used for any other purpose, so I think you want to
say is "don't use this as inspiration.".

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+//
+IPC_SYNC_MESSAGE_ROUTED3_2(ViewMsg_SynchronousFind,
+                           int /* request_id */,
+                           string16 /* search_string */,
+                           WebKit::WebFindOptions /* options */,
+                           int /* Out: Number of occurrences found */,

[jam, 2012/09/19 16:55:43]

nit: skip the "Out:". also, the convention is to put the parameter name inside
the comment, i.e.

int /* match_count */,

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+                           int /* Out: Active ordinal */)
+#endif
+
 // Sent when the user wants to search for a word on the page (find in page).
 IPC_MESSAGE_ROUTED3(ViewMsg_Find,
                     int /* request_id */,