[Android] Upstream the WebView find-in-page API implementation.

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "content/common/content_export.h"
@@ skipping 989 matching lines @@
 
 // Tells the renderer to perform the specified navigation, interrupting any
 // existing navigation.
 IPC_MESSAGE_ROUTED1(ViewMsg_Navigate, ViewMsg_Navigate_Params)
 
 IPC_MESSAGE_ROUTED0(ViewMsg_Stop)
 
 // Tells the renderer to reload the current focused frame
 IPC_MESSAGE_ROUTED0(ViewMsg_ReloadFrame)
 
+#if defined(OS_ANDROID)

[jam, 2012/09/19 16:55:43]

nit: put all the android specific messages together in one ifdef block, at the
end of the declaration of the IPC messages (i.e. right before "Messages sent
from the renderer to the browser.")

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+// Sent when the user wants to search for all occurrences of a word or find
+// the next result in a synchronous way. This method forces the UI thread in
+// the browser to wait for the renderer to reply, therefore blocking the UI.
+//
+// This functionality is required for compatibility with the legacy Android
+// WebView API. As this goes strongly against the Chromium design guidelines,
+// this message should not be used for any other purposes.

[jam, 2012/09/19 16:55:43]

nit: this message _can't_ be used for any other purpose, so I think you want to
say is "don't use this as inspiration.".

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+//
+IPC_SYNC_MESSAGE_ROUTED3_2(ViewMsg_SynchronousFind,
+                           int /* request_id */,
+                           string16 /* search_string */,
+                           WebKit::WebFindOptions /* options */,
+                           int /* Out: Number of occurrences found */,

[jam, 2012/09/19 16:55:43]

nit: skip the "Out:". also, the convention is to put the parameter name inside
the comment, i.e.

int /* match_count */,

[Leandro Graciá Gil, 2012/09/19 18:08:59]

Done.

+                           int /* Out: Active ordinal */)
+#endif
+
 // Sent when the user wants to search for a word on the page (find in page).
 IPC_MESSAGE_ROUTED3(ViewMsg_Find,
                     int /* request_id */,
                     string16 /* search_text */,
                     WebKit::WebFindOptions)
 
 // This message notifies the renderer that the user has closed the FindInPage
 // window (and what action to take regarding the selection).
 IPC_MESSAGE_ROUTED1(ViewMsg_StopFinding,
                     content::StopFindAction /* action */)
@@ skipping 1345 matching lines @@
 // custom normalized fractions of the document size. The rects will be sorted by
 // frame traversal order starting in the main frame, then by dom order.
 //
 // |active_rect| will contain the bounding box of the active find-in-page match
 // marker, in similarly normalized coords (or an empty rect if there isn't one).
 IPC_MESSAGE_ROUTED3(ViewHostMsg_FindMatchRects_Reply,
                     int /* version */,
                     std::vector<gfx::RectF> /* rects */,
                     gfx::RectF /* active_rect */)
 #endif