Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 1093923005: Swap hasPermission with permissionState in browser_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index c0cadf42fafd20e78d903d2fd08cf8bc48225a23..6cb82badd10f96b6d4c022f774fd67a971a8f2c3 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -569,14 +569,14 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
}
#endif
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PermissionStateSaysDefault) {
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PermissionStateSaysPrompt) {
std::string script_result;
ASSERT_TRUE(RunScript("registerServiceWorker()", &script_result));
ASSERT_EQ("ok - service worker registered", script_result);
ASSERT_TRUE(RunScript("permissionState()", &script_result));
- ASSERT_EQ("permission status - default", script_result);
+ ASSERT_EQ("permission status - prompt", script_result);
}
IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PermissionStateSaysGranted) {
@@ -681,7 +681,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
message_loop_runner->Run();
ASSERT_TRUE(RunScript("permissionState()", &script_result));
- EXPECT_EQ("permission status - default", script_result);
+ EXPECT_EQ("permission status - prompt", script_result);
ASSERT_TRUE(RunScript("hasSubscription()", &script_result));
EXPECT_EQ("false - not subscribed", script_result);
@@ -715,7 +715,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
message_loop_runner->Run();
ASSERT_TRUE(RunScript("permissionState()", &script_result));
- EXPECT_EQ("permission status - default", script_result);
+ EXPECT_EQ("permission status - prompt", script_result);
ASSERT_TRUE(RunScript("hasSubscription()", &script_result));
EXPECT_EQ("false - not subscribed", script_result);
@@ -778,7 +778,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
message_loop_runner->Run();
ASSERT_TRUE(RunScript("permissionState()", &script_result));
- EXPECT_EQ("permission status - default", script_result);
+ EXPECT_EQ("permission status - prompt", script_result);
ASSERT_TRUE(RunScript("hasSubscription()", &script_result));
EXPECT_EQ("false - not subscribed", script_result);
@@ -812,7 +812,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
message_loop_runner->Run();
ASSERT_TRUE(RunScript("permissionState()", &script_result));
- EXPECT_EQ("permission status - default", script_result);
+ EXPECT_EQ("permission status - prompt", script_result);
ASSERT_TRUE(RunScript("hasSubscription()", &script_result));
EXPECT_EQ("false - not subscribed", script_result);
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698