Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1093923003: Change FrameTreeNode id from int64 to int. (Closed)

Created:
5 years, 8 months ago by vishal.b
Modified:
5 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change FrameTreeNode id from int64 to int. The FrameTreeNode class has a browser-side and globally unique id. we need id with less bits, for example in extension APIs code exporting those ids to JavaScript. BUG=477770 TBR=sky Committed: https://crrev.com/782eb5db6699322664e7628cab2042c1b8920577 Cr-Commit-Position: refs/heads/master@{#327476}

Patch Set 1 #

Patch Set 2 : Review comments incorporated -Change FrameTreeNode id from int64 to int. #

Patch Set 3 : Change FrameTreeNode id from int64 to int. #

Patch Set 4 : Change FrameTreeNode id from int64 to int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M chrome/browser/ui/browser_navigator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_accessibility.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_accessibility.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_impl_core.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/page_navigator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/page_navigator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_navigation_url_loader_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_navigation_url_loader_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
vishal.b
Please review.
5 years, 8 months ago (2015-04-21 05:32:07 UTC) #2
nasko
There are a lot of calls to this method that all need to be changed. ...
5 years, 8 months ago (2015-04-21 05:44:18 UTC) #3
vishal.b
On 2015/04/21 05:44:18, nasko (very slow until 04-27) wrote: You mean wherever GloballyFindByID() function is ...
5 years, 8 months ago (2015-04-21 05:54:04 UTC) #4
vishal.b
On 2015/04/21 05:54:04, vishal.b wrote: Please review again and let me know if any other ...
5 years, 8 months ago (2015-04-21 06:06:00 UTC) #5
nasko
There are more calls to frame_tree_node_id() than you've covered in your CL. Please do a ...
5 years, 8 months ago (2015-04-22 05:21:24 UTC) #6
vishal.b
On 2015/04/22 05:21:24, nasko (very slow until 04-27) wrote: Please review.
5 years, 8 months ago (2015-04-22 08:25:58 UTC) #7
nasko
LGTM
5 years, 7 months ago (2015-04-28 16:12:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093923003/40001
5 years, 7 months ago (2015-04-29 05:44:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/51899) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-04-29 05:51:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093923003/80001
5 years, 7 months ago (2015-04-29 10:56:11 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 7 months ago (2015-04-29 12:23:04 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:24:01 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/782eb5db6699322664e7628cab2042c1b8920577
Cr-Commit-Position: refs/heads/master@{#327476}

Powered by Google App Engine
This is Rietveld 408576698