cc: Only use upload throttling when performing full texture uploads.

cc: Only use upload throttling when performing full texture uploads.

This reduces the complexity of CCTextureUpdateController::updateTextures
significantly.

BUG=145825
TEST=cc_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157352

[nduca, 2012-09-18 06:03:58]

https://codereview.chromium.org/10937007/diff/1/cc/CCTextureUpdateController.cpp
File cc/CCTextureUpdateController.cpp (right):

https://codereview.chromium.org/10937007/diff/1/cc/CCTextureUpdateController....
cc/CCTextureUpdateController.cpp:58: if (uploadCount)
I'm so confused, how do you even have incremental uploads for the full case?
This patch looks like you disabled everything completely.

[nduca, 2012-09-18 06:12:16]

Or reading more, it seems like this is a single-thread proxy only patch? It
doesn't seem to affect the path that CCProxy uses at all?

[p.s. i think its really confusing that ccsinglethreadproxy doesn't have a
controller at all. Why can't it have a controller, call begin/finalize on it,
and the static updateTextures method can be renamed to say what it does, and
made private?]

[reveman, 2012-09-18 06:22:10]

On 2012/09/18 06:12:16, nduca wrote:
> Or reading more, it seems like this is a single-thread proxy only patch? It
> doesn't seem to affect the path that CCProxy uses at all?

CCTextureUpdateController uses this function from finalize().

> 
> [p.s. i think its really confusing that ccsinglethreadproxy doesn't have a
> controller at all. Why can't it have a controller, call begin/finalize on it,
> and the static updateTextures method can be renamed to say what it does, and
> made private?]

Yup, that's exactly what my plan is. I'm going to just remove updateTextures
completely and move the code into finalize(). I can do all that in this CL if
you like?

[reveman, 2012-09-18 06:26:03]

https://codereview.chromium.org/10937007/diff/1/cc/CCTextureUpdateController.cpp
File cc/CCTextureUpdateController.cpp (right):

https://codereview.chromium.org/10937007/diff/1/cc/CCTextureUpdateController....
cc/CCTextureUpdateController.cpp:58: if (uploadCount)
On 2012/09/18 06:03:58, nduca wrote:
> I'm so confused, how do you even have incremental uploads for the full case?
> This patch looks like you disabled everything completely.

Incremental uploads are now done in
CCTextureUpdateController::updateMoreTexturesNow(). This is only used by the
single thread proxy and when finalize is called.

[nduca, 2012-09-18 06:28:24]

Gotcha, LGTM. You can land this and do another patch if you want.

[commit-bot: I haz the power, 2012-09-18 07:59:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/10937007/2004

[commit-bot: I haz the power, 2012-09-18 10:26:17]

Retried try job too often for step(s) browser_tests, unit_tests

[commit-bot: I haz the power, 2012-09-18 12:49:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/10937007/2004

[commit-bot: I haz the power, 2012-09-18 14:46:16]

Change committed as 157352