Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: test/generated_sdk/lib/core/list.dart

Issue 1093353004: fix list initializers (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: baselines Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/generated_sdk/lib/core/int.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/generated_sdk/lib/core/list.dart
diff --git a/test/generated_sdk/lib/core/list.dart b/test/generated_sdk/lib/core/list.dart
index de16d5263936f446d315b974e0b5771837e2f3de..9168fbaef0990de4bf5ed9485fa9c1e40cd97ef4 100644
--- a/test/generated_sdk/lib/core/list.dart
+++ b/test/generated_sdk/lib/core/list.dart
@@ -110,16 +110,12 @@ abstract class List<E> implements Iterable<E>, EfficientLength {
* otherwise, it returns a fixed-length list.
*/
factory List.from(Iterable elements, { bool growable: true }) {
- // TODO(jmesserly): fix this. This is just to unblock initial SDK check in.
- return null;
- /*
List<E> list = new List<E>();
for (E e in elements) {
list.add(e);
}
if (growable) return list;
return makeListFixedLength(list);
- */
}
/**
« no previous file with comments | « test/generated_sdk/lib/core/int.dart ('k') | tool/input_sdk/patch/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698