Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: cc/CCThreadProxy.cpp

Issue 10933095: cc: Remove resource updates from scheduler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/CCTextureUpdateController.cpp ('K') | « cc/CCTextureUpdateControllerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/CCThreadProxy.cpp
diff --git a/cc/CCThreadProxy.cpp b/cc/CCThreadProxy.cpp
index 009ac1cd17dbcc1ac1748eb8fe1287da4c0bc232..085aecdbceb57daff5524cbe6e292ad5f9e26787 100644
--- a/cc/CCThreadProxy.cpp
+++ b/cc/CCThreadProxy.cpp
@@ -593,12 +593,10 @@ void CCThreadProxy::beginFrameCompleteOnImplThread(CCCompletionEvent* completion
setNeedsCommitOnImplThread();
}
- bool hasResourceUpdates = queue->hasMoreUpdates();
- if (hasResourceUpdates)
- m_currentTextureUpdateControllerOnImplThread = CCTextureUpdateController::create(this, CCProxy::implThread(), queue, m_layerTreeHostImpl->resourceProvider(), m_layerTreeHostImpl->renderer()->textureCopier(), m_layerTreeHostImpl->renderer()->textureUploader());
- m_commitCompletionEventOnImplThread = completion;
+ m_currentTextureUpdateControllerOnImplThread = CCTextureUpdateController::create(this, CCProxy::implThread(), queue, m_layerTreeHostImpl->resourceProvider(), m_layerTreeHostImpl->renderer()->textureCopier(), m_layerTreeHostImpl->renderer()->textureUploader());
+ m_currentTextureUpdateControllerOnImplThread->start();
- m_schedulerOnImplThread->beginFrameComplete(hasResourceUpdates);
+ m_commitCompletionEventOnImplThread = completion;
}
void CCThreadProxy::beginFrameAbortedOnImplThread()
@@ -611,11 +609,9 @@ void CCThreadProxy::beginFrameAbortedOnImplThread()
m_schedulerOnImplThread->beginFrameAborted();
}
-void CCThreadProxy::scheduledActionUpdateMoreResources(double monotonicTimeLimit)
+void CCThreadProxy::scheduledActionUpdateMoreResources(double)
jamesr 2012/09/17 06:57:38 why is this function still here? what's it do?
reveman 2012/09/17 15:32:52 Nothing. As I mentioned in my initial comment, the
{
TRACE_EVENT0("cc", "CCThreadProxy::scheduledActionUpdateMoreResources");
- ASSERT(m_currentTextureUpdateControllerOnImplThread);
- m_currentTextureUpdateControllerOnImplThread->updateMoreTextures(monotonicTimeLimit);
}
void CCThreadProxy::scheduledActionCommit()
@@ -623,7 +619,10 @@ void CCThreadProxy::scheduledActionCommit()
TRACE_EVENT0("cc", "CCThreadProxy::scheduledActionCommit");
ASSERT(isImplThread());
ASSERT(m_commitCompletionEventOnImplThread);
+ ASSERT(m_currentTextureUpdateControllerOnImplThread);
+ // Complete remaining updates.
+ m_currentTextureUpdateControllerOnImplThread->updateAllTexturesNow();
m_currentTextureUpdateControllerOnImplThread.clear();
m_layerTreeHostImpl->beginCommit();
@@ -764,7 +763,7 @@ CCScheduledActionDrawAndSwapResult CCThreadProxy::scheduledActionDrawAndSwapForc
void CCThreadProxy::updateTexturesCompleted()
{
ASSERT(isImplThread());
- m_schedulerOnImplThread->updateResourcesComplete();
+ m_schedulerOnImplThread->beginFrameComplete(false);
}
void CCThreadProxy::didCommitAndDrawFrame()
« cc/CCTextureUpdateController.cpp ('K') | « cc/CCTextureUpdateControllerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698