Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10933082: Remove .dmg from the list of dangerous file extensions for Mac OS X. (Closed)

Created:
8 years, 3 months ago by palmer
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Remove .dmg from the list of dangerous file extensions for Mac OS X. While here, add some that are dangerous. BUG=29287, 19096 TEST=When downloading .bash, .command, .csh, .ksh, .sh, .tcsh files, expect the "The file may harm your computer" warning. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158470

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/download/download_extensions.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Chris Palmer
In http://code.google.com/p/chromium/issues/detail?id=19096#c26, stuartmorgan suggests using an empty list of dangerous downloads, falling back on the ...
8 years, 3 months ago (2012-09-13 23:36:38 UTC) #1
Nico
lgtm fine with me
8 years, 3 months ago (2012-09-14 00:38:08 UTC) #2
Randy Smith (Not in Mondays)
Happy to go with your judgement on this. LGTM.
8 years, 3 months ago (2012-09-14 12:52:58 UTC) #3
Randy Smith (Not in Mondays)
On 2012/09/14 12:52:58, rdsmith wrote: > Happy to go with your judgement on this. > ...
8 years, 3 months ago (2012-09-14 15:21:50 UTC) #4
palmer
> I just added a note to 29287 expressing concern about IDME (== downloading > ...
8 years, 3 months ago (2012-09-14 21:19:02 UTC) #5
stuartmorgan
LGTM We may want to move to: #elif defined(OS_POSIX) <lots of stuff> #if !defined(OS_MACOSX) <a ...
8 years, 3 months ago (2012-09-17 05:44:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/10933082/1
8 years, 3 months ago (2012-09-24 20:45:18 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 23:29:06 UTC) #8
Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698