Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: chrome/browser/download/download_extensions.cc

Issue 10933082: Remove .dmg from the list of dangerous file extensions for Mac OS X. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_extensions.cc
===================================================================
--- chrome/browser/download/download_extensions.cc (revision 158295)
+++ chrome/browser/download/download_extensions.cc (working copy)
@@ -176,9 +176,14 @@
{ "wsh", AllowOnUserGesture },
{ "xbap", Dangerous },
#elif defined(OS_MACOSX)
- // TODO(thakis): Figure out what makes sense here -- crbug.com/19096
- { "app", AllowOnUserGesture },
- { "dmg", AllowOnUserGesture },
+ { "bash", AllowOnUserGesture },
+ { "command", AllowOnUserGesture },
+ { "csh", AllowOnUserGesture },
+ { "ksh", AllowOnUserGesture },
+ { "pkg", AllowOnUserGesture },
+ { "sh", AllowOnUserGesture },
+ { "shar", AllowOnUserGesture },
+ { "tcsh", AllowOnUserGesture },
#elif defined(OS_POSIX)
// TODO(estade): lengthen this list.
{ "bash", AllowOnUserGesture },
@@ -188,6 +193,7 @@
{ "ksh", AllowOnUserGesture },
{ "rpm", AllowOnUserGesture },
{ "sh", AllowOnUserGesture },
+ { "shar", AllowOnUserGesture },
{ "tcsh", AllowOnUserGesture },
#endif
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698