Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1093223006: WebRtcVideoCapturerAdapter mods for Texture-backed VideoFrames (Closed)

Created:
5 years, 8 months ago by mcasas
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRtcVideoCapturerAdapter mods for Texture-backed VideoFrames Interestingly, it is very similar to https://codereview.chromium.org/277943002 ! BUG=440843, 362521 Committed: https://crrev.com/587bef6913c51ede04b0f40f3a36e33a36c8297e Cr-Commit-Position: refs/heads/master@{#326872}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Removed superfluous header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mcasas
magjed@ PTAL. Highly speculative.
5 years, 8 months ago (2015-04-22 20:59:47 UTC) #3
mcasas
wuchengli@ PTAL.
5 years, 8 months ago (2015-04-23 21:41:12 UTC) #5
wuchengli1
Sorry. I'm OOO until next Monday. I'll be back next Tuesday.
5 years, 8 months ago (2015-04-24 07:01:14 UTC) #7
magjed_chromium
lgtm https://codereview.chromium.org/1093223006/diff/20001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1093223006/diff/20001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode10 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:10: #include "gpu/command_buffer/common/mailbox_holder.h" Why is this include needed?
5 years, 8 months ago (2015-04-24 07:35:34 UTC) #8
mcasas
dalecurtis@ RS plz. https://codereview.chromium.org/1093223006/diff/20001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/1093223006/diff/20001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode10 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:10: #include "gpu/command_buffer/common/mailbox_holder.h" On 2015/04/24 07:35:34, magjed ...
5 years, 8 months ago (2015-04-24 18:34:29 UTC) #10
DaleCurtis
rs lgtm
5 years, 8 months ago (2015-04-24 19:16:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1093223006/40001
5 years, 8 months ago (2015-04-24 19:19:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-24 20:54:49 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 20:56:03 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/587bef6913c51ede04b0f40f3a36e33a36c8297e
Cr-Commit-Position: refs/heads/master@{#326872}

Powered by Google App Engine
This is Rietveld 408576698