Issue 277943002: Add texture support in WebrtcVideoCapturerAdapter.

Issue 277943002: Add texture support in WebrtcVideoCapturerAdapter. (Closed)

Created:
6 years, 7 months ago by wuchengli

Modified:
6 years, 4 months ago

Reviewers:
perkj_chrome, Ami GONE FROM CHROMIUM, Alpha Left Google

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, Pawel Osciak

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add texture support in WebrtcVideoCapturerAdapter. Corresponding CLs: https://webrtc-codereview.appspot.com/12499004 http://cl/66620352 BUG=362437 TEST=WebRTC stream forwarding on CrOS.

Patch Set 2 : fix indentation #

Patch Set 4 : address Ami's comments #

Patch Set 6 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc	View	1 2 3 4	3 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

perkj_chrome

https://codereview.chromium.org/277943002/diff/1/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/277943002/diff/1/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode106 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:106: new webrtc::RefCountImpl<NativeHandleImpl>(frame.get()); nit:indentation https://codereview.chromium.org/277943002/diff/1/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode107 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:107: captured_frame.handle = handle; How ...

6 years, 7 months ago (2014-05-12 08:19:42 UTC) #2

wuchengli

https://codereview.chromium.org/277943002/diff/1/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/277943002/diff/1/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode106 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:106: new webrtc::RefCountImpl<NativeHandleImpl>(frame.get()); On 2014/05/12 08:19:42, perkj wrote: > nit:indentation ...

6 years, 7 months ago (2014-05-12 09:41:28 UTC) #3

Ami GONE FROM CHROMIUM

https://codereview.chromium.org/277943002/diff/40001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/277943002/diff/40001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode100 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:100: // TODO(perkj): I guess this comment now belongs at ...

6 years, 7 months ago (2014-05-12 19:59:11 UTC) #4

wuchengli

PTAL https://codereview.chromium.org/277943002/diff/40001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc File content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc (right): https://codereview.chromium.org/277943002/diff/40001/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc#newcode100 content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc:100: // TODO(perkj): On 2014/05/12 19:59:12, Ami Fischman wrote: ...

6 years, 7 months ago (2014-05-13 07:28:53 UTC) #5

Alpha Left Google

I don't think I understand this code well enough to review it. Removing myself.

6 years, 7 months ago (2014-05-14 21:56:05 UTC) #8

Alpha Left Google

6 years, 7 months ago (2014-05-14 21:56:06 UTC) #9

I don't think I understand this code well enough to review it. Removing myself.

Expand Messages | Collapse Messages