core/include/fpdfapi/fpdf_pageobj.h - Issue 1093213002: Remove Release() from CPDF_PageObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_pageobj.h

Issue 1093213002: Remove Release() from CPDF_PageObject (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_pageobj.h

diff --git a/core/include/fpdfapi/fpdf_pageobj.h b/core/include/fpdfapi/fpdf_pageobj.h

index bd11a209f05a296a44ba61494be43fee55e527a7..d3bb9916806c2f519167f24b2c4306b4e9fb73d5 100644

--- a/core/include/fpdfapi/fpdf_pageobj.h

+++ b/core/include/fpdfapi/fpdf_pageobj.h

@@ -455,10 +455,8 @@ public:

class CPDF_PageObject : public CPDF_GraphicStates

{

public:

static CPDF_PageObject* Create(int type);

- void Release();

+ virtual ~CPDF_PageObject() { }

Lei Zhang 2015/04/20 19:21:59 Can we move the dtor impl, however small, into the

Tom Sepez 2015/04/20 19:29:01 Done.

CPDF_PageObject* Clone() const;

@@ -505,7 +503,6 @@ protected:

CPDF_PageObject() {}

- virtual ~CPDF_PageObject() {}

};

struct CPDF_TextObjectItem {

« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_page/fpdf_page.cpp » ('j') | no next file with comments »