Remove Release() from CPDF_PageObject

core/include/fpdfapi/fpdf_pageobj.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FPDF_PAGEOBJ_H_
 #define _FPDF_PAGEOBJ_H_
 #ifndef _FPDF_RESOURCE_
 #include "fpdf_resource.h"
@@ skipping 437 matching lines @@
 
     CPDF_ColorState             m_ColorState;
 
     CPDF_TextState              m_TextState;
 
     CPDF_GeneralState   m_GeneralState;
 };
 class CPDF_PageObject : public CPDF_GraphicStates
 {
 public:
-
     static CPDF_PageObject* Create(int type);
-
-    void                                Release();
+    virtual ~CPDF_PageObject() { }

[Lei Zhang, 2015/04/20 19:21:59]

Can we move the dtor impl, however small, into the .cpp file?

[Tom Sepez, 2015/04/20 19:29:01]

Done.

 
     CPDF_PageObject*    Clone() const;
 
     void                                Copy(const CPDF_PageObject* pSrcObject);
 
     virtual void                Transform(const CFX_AffineMatrix& matrix) = 0;
 
 
 
     void                                RemoveClipPath();
@@ skipping 26 matching lines @@
 
     CPDF_ContentMark    m_ContentMark;
 protected:
 
     virtual void                CopyData(const CPDF_PageObject* pSrcObject) {}
 
     void                                RecalcBBox();
 
     CPDF_PageObject() {}
 
-    virtual ~CPDF_PageObject() {}
 };
 struct CPDF_TextObjectItem  {
 
     FX_DWORD                    m_CharCode;
 
     FX_FLOAT                    m_OriginX;
 
     FX_FLOAT                    m_OriginY;
 };
 class CPDF_TextObject : public CPDF_PageObject
@@ skipping 195 matching lines @@
     CFX_DIBitmap*               m_pBitmap;
 
     CFX_ArrayTemplate<CFX_AffineMatrix> m_Matrices;
 
     void                                AddMatrix(CFX_AffineMatrix& matrix);
 protected:
     virtual void                Transform(const CFX_AffineMatrix& matrix) {}
     virtual void                CopyData(const CPDF_PageObject* pSrcObjet) {}
 };
 #endif