runtime/observatory/tests/service/gc_test.dart - Issue 1093043004: Do not JSON encode the 'result' of a service rpc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/gc_test.dart

Issue 1093043004: Do not JSON encode the 'result' of a service rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: edits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/observatory/lib/src/service/object.dart ('K') | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/observatory/tests/service/isolate_lifecycle_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/gc_test.dart

diff --git a/runtime/observatory/tests/service/gc_test.dart b/runtime/observatory/tests/service/gc_test.dart

index 736ccc13a1c2d2b85d94048e65edaad3b2927149..49e653ea9921e1da527a5c33e55ff77e9c95d584 100644

--- a/runtime/observatory/tests/service/gc_test.dart

+++ b/runtime/observatory/tests/service/gc_test.dart

@@ -28,8 +28,11 @@ var tests = [

// Expect at least this many GC events.

int gcCountdown = 3;

isolate.vm.events.stream.listen((ServiceEvent event) {

- if (event.eventType == ServiceEvent.kGC && --gcCountdown == 0) {

- completer.complete();

+ if (event.eventType == ServiceEvent.kGC) {

+ print('Received GC event');

Cutch 2015/04/21 23:38:53 remove print.

turnidge 2015/04/23 17:51:59 I actually left this in on purpose.

+ if (--gcCountdown == 0) {

+ completer.complete();

+ }

}

});

return completer.future;