Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: runtime/observatory/tests/service/gc_test.dart

Issue 1093043004: Do not JSON encode the 'result' of a service rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: edits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'test_helper.dart'; 7 import 'test_helper.dart';
8 8
9 import 'dart:async'; 9 import 'dart:async';
10 10
(...skipping 10 matching lines...) Expand all
21 grow(100, 1 << 24, new Duration(seconds: 1)); 21 grow(100, 1 << 24, new Duration(seconds: 1));
22 } 22 }
23 23
24 var tests = [ 24 var tests = [
25 25
26 (Isolate isolate) { 26 (Isolate isolate) {
27 Completer completer = new Completer(); 27 Completer completer = new Completer();
28 // Expect at least this many GC events. 28 // Expect at least this many GC events.
29 int gcCountdown = 3; 29 int gcCountdown = 3;
30 isolate.vm.events.stream.listen((ServiceEvent event) { 30 isolate.vm.events.stream.listen((ServiceEvent event) {
31 if (event.eventType == ServiceEvent.kGC && --gcCountdown == 0) { 31 if (event.eventType == ServiceEvent.kGC) {
32 completer.complete(); 32 print('Received GC event');
Cutch 2015/04/21 23:38:53 remove print.
turnidge 2015/04/23 17:51:59 I actually left this in on purpose.
33 if (--gcCountdown == 0) {
34 completer.complete();
35 }
33 } 36 }
34 }); 37 });
35 return completer.future; 38 return completer.future;
36 }, 39 },
37 40
38 ]; 41 ];
39 42
40 main(args) => runIsolateTests(args, tests, testeeConcurrent: script); 43 main(args) => runIsolateTests(args, tests, testeeConcurrent: script);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698