Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
index 117618736aed3136333e9d78c8fb52b858e206da..487b92eb805ccee85e38e00a83d3c21458dae758 100644
--- a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc
@@ -177,7 +177,7 @@ PlatformKeysInternalSelectClientCertificatesFunction::Run() {
void PlatformKeysInternalSelectClientCertificatesFunction::
OnSelectedCertificates(scoped_ptr<net::CertificateList> matches,
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!error_message.empty()) {
Respond(Error(error_message));
return;
@@ -266,7 +266,7 @@ ExtensionFunction::ResponseAction PlatformKeysInternalSignFunction::Run() {
void PlatformKeysInternalSignFunction::OnSigned(
const std::string& signature,
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (error_message.empty())
Respond(ArgumentList(api_pki::Sign::Results::Create(
std::vector<char>(signature.begin(), signature.end()))));

Powered by Google App Engine
This is Rietveld 408576698