Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1092933005: Revert of [Temporary On Will revert on Fri] UI impl side painting default on (Closed)

Created:
5 years, 8 months ago by Alexander Potapenko
Modified:
5 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Temporary On Will revert on Fri] UI impl side painting default on (patchset #12 id:290001 of https://codereview.chromium.org/962833003/) Reason for revert: I suspect this CL broke the MSan bots, see https://crbug.com/479133 The trybots are happy upon revert. Original issue's description: > [Temporary On will revert on Fri]UI impl side painting default on > > Turn on Impl Side Painting on Aura browser compositor by default > and add a disable compositor switch. > > Temporarily turn on this patch to flush out potential bugs. Will > revert on Friday. > > R=danakj > BUG=314185 > > Committed: https://crrev.com/ee6eff90528b8c5b0c10e6faf643edac074ff4b7 > Cr-Commit-Position: refs/heads/master@{#325985} TBR=danakj@chromium.org,enne@chromium.org,piman@chromium.org,reveman@chromium.org,weiliangc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=314185 Committed: https://crrev.com/7859e71922205e241ef91d20a5b9032c90e6d4d3 Cr-Commit-Position: refs/heads/master@{#326276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alexander Potapenko
Created Revert of [Temporary On Will revert on Fri] UI impl side painting default on
5 years, 8 months ago (2015-04-21 13:59:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092933005/1
5 years, 8 months ago (2015-04-22 12:56:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 12:56:56 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 12:57:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7859e71922205e241ef91d20a5b9032c90e6d4d3
Cr-Commit-Position: refs/heads/master@{#326276}

Powered by Google App Engine
This is Rietveld 408576698