Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4611)

Unified Diff: chrome/browser/ui/webui/large_icon_source.h

Issue 1092873002: [Icons NTP] Refactor large_icon_source to extract the logic shared between desktop and Android to f… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/large_icon_source.h
diff --git a/chrome/browser/ui/webui/large_icon_source.h b/chrome/browser/ui/webui/large_icon_source.h
index 05872d2a1917eb70316a1d4661c5f065cad2d0b7..cd9de9907b05f4a38d59ee62fe97106dfa6b73d7 100644
--- a/chrome/browser/ui/webui/large_icon_source.h
+++ b/chrome/browser/ui/webui/large_icon_source.h
@@ -70,7 +70,7 @@ class LargeIconSource : public content::URLDataSource {
// Callback for icon data retrieval request.
void OnIconDataAvailable(
const IconRequest& request,
- const favicon_base::FaviconRawBitmapResult& bitmap_result);
+ const favicon_base::LargeIconResult& bitmap_result);
// Renders and sends a default fallback icon. This is used when there is no
// known text and/or foreground color to use for the generated icon (it
@@ -92,12 +92,6 @@ class LargeIconSource : public content::URLDataSource {
favicon::FallbackIconService* fallback_icon_service_;
- // A pre-populated list of the types of icon files to consider when looking
- // for the largest matching icon.
- // Note: this is simply an optimization over populating an icon type vector
- // on each request.
- std::vector<int> large_icon_types_;
-
DISALLOW_COPY_AND_ASSIGN(LargeIconSource);
};
« no previous file with comments | « no previous file | chrome/browser/ui/webui/large_icon_source.cc » ('j') | chrome/browser/ui/webui/large_icon_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698